Skip to content

[candidate_profile] Translate Candidate Info widget on candidate_profile #10024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 15, 2025
Merged

[candidate_profile] Translate Candidate Info widget on candidate_profile #10024

merged 3 commits into from
Oct 15, 2025

Conversation

driusan
Copy link
Collaborator

@driusan driusan commented Sep 22, 2025

This translates the first candidate info widget on the candidatE_profile page.

Japanese is used as the sample language.

(It also required adding an "english" translation so that msgid_plural is recognized for the Cohort(s) label instead of hardcoding adding an "s" in the code.)

@driusan driusan added the Multilingual Any tasks related to making LORIS multilingual label Sep 22, 2025
@github-actions github-actions bot added Language: PHP PR or issue that update PHP code Language: Javascript PR or issue that update Javascript code Module: candidate_list PR or issue related to candidate_list module Module: candidate_parameters PR or issue related to candidate_parameters module Module: candidate_profile PR or issue related to candidate_profile module labels Sep 22, 2025
@driusan driusan force-pushed the TranslateCandidateProfile branch 2 times, most recently from ab2659a to 4e5f310 Compare September 26, 2025 12:53
@racostas racostas self-requested a review September 26, 2025 14:10
racostas
racostas requested changes Sep 26, 2025
View reviewed changes
Copy link
Contributor

@racostas racostas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • There is one translation that don't seems to be loading.
  • For the format of the day I think I do prefer like in the original 2016-05-01 or 2016/05/01 than just 2026/5/1... also not sure if this is the Japanese format.
image

@racostas racostas added the State: Needs work PR awaiting additional work by the author to proceed label Sep 26, 2025
@racostas
Copy link
Contributor

Regarding the date, this is what it's in the "general" configuration
image
That doesn't seems to match with with translated version.
I also don't seems to find it in the particular users preferences:
image

Dave MacFarlane added 2 commits October 15, 2025 13:47
[candidate_profile] Translate Candidate Info widget on candidate_prof…
ef494b3 
…ile page

This translates the first candidate info widget on the candidatE_profile page.

Japanese is used as the sample language.
Format date according to locale
fe38854
@driusan driusan force-pushed the TranslateCandidateProfile branch from 4e5f310 to fe38854 Compare October 15, 2025 17:47
@driusan
Copy link
Collaborator Author

driusan commented Oct 15, 2025

@racostas I rebased and the tests seem to be passing now.

For the dates, I don't think the YM/YMD config was ever honoured on this page. The code is using the IntlDateFormatter to format it according to the user's locale. There's no specific setting, because it uses the standard for the region.

Not sure why Caveat isn't getting translated for you? Did you run make? It is getting translated for me and is in the .po file.

@racostas
Copy link
Contributor

@racostas I rebased and the tests seem to be passing now.

For the dates, I don't think the YM/YMD config was ever honoured on this page. The code is using the IntlDateFormatter to format it according to the user's locale. There's no specific setting, because it uses the standard for the region.

Not sure why Caveat isn't getting translated for you? Did you run make? It is getting translated for me and is in the .po file.

@driusan, sound good for the date format. I did a bit of investigation and its seems is only honoured ( partially ) in new_profile and maybe others I could be missing ... possible instruments but not all across LORIS ... something we can think a bit about but definitively preexisting and not related with this PR.

For the Caveat it seems it was cached somehow by the webserver or the browser.. after reboot + refresh it's showing properly now:
image

@racostas racostas self-requested a review October 15, 2025 19:00
racostas
racostas approved these changes Oct 15, 2025
View reviewed changes
Copy link
Contributor

@racostas racostas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@racostas racostas added Passed manual tests PR has been successfully tested by at least one peer and removed State: Needs work PR awaiting additional work by the author to proceed labels Oct 15, 2025
@driusan driusan merged commit 0859c3a into aces:main Oct 15, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@racostas racostas racostas approved these changes

Assignees

@racostas racostas

Labels

Language: Javascript PR or issue that update Javascript code Language: PHP PR or issue that update PHP code Module: candidate_list PR or issue related to candidate_list module Module: candidate_parameters PR or issue related to candidate_parameters module Module: candidate_profile PR or issue related to candidate_profile module Multilingual Any tasks related to making LORIS multilingual Passed manual tests PR has been successfully tested by at least one peer

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@driusan @racostas